adds notice for quizzes created pre-0.17.x #13045

AllanOXDi · 2025-01-31T19:58:06Z

Summary

In version 0.17, the question_sources field structure was updated, introducing the DraftExam and Exam models. Quizzes created in versions ≥0.17.x start as DraftExam and convert to Exam . However, quizzes created prior to 0.17.x (without DraftExam ) may exist in an uneditable state if the user upgraded Kolibri without starting the quiz. This PR
add notice for legacy quiz created pre-0.17.x) should not be uneditable but should see

"This quiz was created using an older version of Kolibri and cannot be edited directly. Create a copy of it to edit the resources."
closes #12954

References

#12954

Reviewer guidance

Import any older version on quizzes created prior to 0.17.x and try to edit if the quiz has not been started

github-actions · 2025-01-31T20:32:13Z

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.18.0a3.dev0_git.49.g3cd93c53.pex
Windows Installer (EXE)	kolibri-0.18.0a3.dev0+git.49.g3cd93c53-windows-setup-unsigned.exe
Debian Package	kolibri_0.18.0a3.dev0+git.49.g3cd93c53-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.18.0a3.dev0+git.49.g3cd93c53.dmg
Android Package (APK)	kolibri-0.18.0a3.dev0+git.49.g3cd93c53-0.1.4-debug.apk
Raspberry Pi Image	kolibri-pi-image-0.18.0a3.dev0+git.49.g3cd93c53.zip
TAR file	kolibri-0.18.0a3.dev0+git.49.g3cd93c53.tar.gz
WHL file	kolibri-0.18.0a3.dev0+git.49.g3cd93c53-py2.py3-none-any.whl

AllanOXDi · 2025-02-06T17:03:47Z

kolibri/plugins/coach/assets/src/views/quizzes/QuizSummaryPage/QuizOptionsDropdownMenu.vue

@@ -41,7 +41,7 @@
          },
          { label: this.coreString('deleteAction'), value: 'DELETE' },
        ];
-        if (!this.exam?.archive) {
+        if (this.exam?.data_model_version > 2) {


@radinamatic @marcellamaki @nucleogenesis . I think we should disabled the edit details all together if the data_modal_version < 3 ?

That sort of crossed my mind too, when I was considering the string... 🤔

But Edit details (quiz title and description, not the resources) should still be available, right?

Hmmm- I think no- You have to first make a copy to do that.

I think that hiding it is a good call. This is a very unlikely case for someone to be in and the solution is clearly shown to the user w/ the changes here

nucleogenesis · 2025-02-11T18:21:41Z

kolibri/plugins/coach/assets/src/views/quizzes/QuizSummaryPage/QuizOptionsDropdownMenu.vue

@@ -41,7 +41,7 @@
          },
          { label: this.coreString('deleteAction'), value: 'DELETE' },
        ];
-        if (!this.exam?.archive) {
+        if (this.exam?.data_model_version > 2) {


I think that hiding it is a good call. This is a very unlikely case for someone to be in and the solution is clearly shown to the user w/ the changes here

nucleogenesis · 2025-02-11T20:30:48Z

kolibri/plugins/coach/assets/src/views/common/QuizLessonDetailsHeader.vue

@@ -72,6 +86,9 @@
      resource() {
        return this.examOrLesson === 'lesson' ? this.lesson : this.exam;
      },
+      isFromOldKolibiri() {
+        return this.exam.data_model_version < 3 && this.exam.draft && !this.exam.active;


I don't see the notice and I believe it's because of the this.exam.draft which is only set on DraftExam models.

Because the quiz was created before DraftExam models existed, they're not going to be marked as a draft here.

I made the change locally and see the banner as expected.

nucleogenesis

A few comments below that I think can be updated. You might want to check directly w/ @radinamatic or @marcellamaki tomorrow re: the color of the notice.

One other thing to add is that there should probably be a half-em of margin above the UiAlert so that there's some room between it and the title+buttons when shown.

nucleogenesis · 2025-02-11T20:34:12Z

kolibri/plugins/coach/assets/src/views/common/QuizLessonDetailsHeader.vue

@@ -27,6 +27,11 @@
      </div>
    </div>
    <MissingResourceAlert v-if="resource.missing_resource" />
+    <UiAlert v-if="isFromOldKolibiri">


We should probably add type="warning" here - thoughts @radinamatic ?

The default "info" type results in a blue section w/ an info (i) icon, but warning is yellow w/ the /!\ triangle exclamation icon.

Agreed on both accounts @nucleogenesis (re: margin and), yellow color for the notice/alert may be better suited for this case 👍🏽

akolson · 2025-02-12T06:06:57Z

kolibri/plugins/coach/assets/src/views/common/QuizLessonDetailsHeader.vue

@@ -72,6 +86,9 @@
      resource() {
        return this.examOrLesson === 'lesson' ? this.lesson : this.exam;
      },
+      isFromOldKolibiri() {
+        return this.exam.data_model_version < 3 && this.exam.draft && !this.exam.active;


We could refactor this into several props instead for better clarity, testability and maintainability;

isOldDataModelVersion() { return this.exam.data_model_version < 3; } isDraft() { return this.exam.draft; } isActive() { return this.exam.active; } isFromOldKolibiri() { return this.isOldDataModelVersion() && this.isDraft() && !this.isActive(); }

And in the alert, it would now be;

<UiAlert v-if="isFromOldKolibiri"> ..... </UiAlert>

This should take into consideration @nucleogenesis's feedback here and here

akolson · 2025-02-12T06:10:00Z

kolibri/plugins/coach/assets/src/views/quizzes/QuizSummaryPage/QuizOptionsDropdownMenu.vue

@@ -41,7 +41,7 @@
          },
          { label: this.coreString('deleteAction'), value: 'DELETE' },
        ];
-        if (!this.exam?.archive) {
+        if (this.exam?.data_model_version > 2) {


Would 3 represent our most current exam?

Yes and it would means it comes after DraftExam existed.

akolson

Hi @AllanOXDi! I think this is looking great already. I left you a thought and question. I also think we could easily write up tests for the newly added notice based on the different scenarios described in the isFromOldKolibiri.

AllanOXDi · 2025-02-12T14:13:39Z

Thank you both @akolson and @nucleogenesis . I will wait for the final thought from @radinamatic and @marcellamaki.

radinamatic · 2025-02-13T16:25:11Z

I installed the DEB asset from this PR in an Ubuntu VM with a previous 0.16.2 version of Kolibri, where I had a couple of not-started quizzes. I could see that the Edit details option was removed when I open a non-started quiz, but there was no sign of an alert explaining why is the editing of resources disabled/impossible in both Firefox and Chrome.

In addition to that, the quiz preview is not working correctly (question images are not displayed), although I'm unsure if that regression is caused by changes in this PR.

No alert	No preview

db-logs.zip

AllanOXDi · 2025-02-13T17:50:11Z

Hmmm, thats strange , could you help me share the kolibri home folder that you used. Because it seems to be working on my end.

radinamatic · 2025-02-13T20:00:10Z

Hmmm, thats strange , could you help me share the kolibri home folder that you used. Because it seems to be working on my end.

@AllanOXDi I'll upload the whole home folder if you need it, but you already have the DB and logs attached in my previous comment (maybe all you would require is to import the QA channel...?)

AllanOXDi · 2025-03-07T14:15:12Z

@radinamatic this should be fixed now

marcellamaki

Hi @AllanOXDi - I'll let @radinamatic follow up on the QA side here, but I have two small requests in terms of variable naming that would help with readability. Let me know if you have any questions!

marcellamaki · 2025-03-10T14:36:12Z

kolibri/plugins/coach/assets/src/views/common/QuizLessonDetailsHeader.vue

+      isOldDataModelVersion() {
+        return this.exam.data_model_version < 3;
+      },
+      isFromOldKolibiri() {


You have a small typo here - it's consistent, but let's update isFromOldKolibiri to isFromOldKolibri

marcellamaki · 2025-03-10T14:38:18Z

kolibri/plugins/coach/assets/src/views/common/QuizLessonDetailsHeader.vue

+      v-if="isFromOldKolibiri && hideAlert"
+      type="warning"
+      class="old-kolibri-banner"
+      @dismiss="hideAlert = false"


I'm finding the hideAlert here a little bit confusing. When I see that variable name, I would assume that it means that the UiAlert is not visible. However, since isFromOldKolibiri && hideAlert would have to be true for this to render, it means that hideAlert would be true for this to show. And, the @dismiss setting hideAlert to false.

I think having this be showAlert would be clearer.

radinamatic · 2025-03-10T21:57:20Z

Progress with the notification, but we're not there yet... After the upgrade to 0.18:

quiz originally made on Kolibri 0.16 (but not started) now displays the notification and cannot be edited ✔️
copy of that quiz that was originally created on 0.16 is not editable (is missing the Edit/Manage resources option) ❌ 😞
even a brand new quiz created now on 0.18 cannot be edited (if not started) ❌ 😭

0.16 quiz	copy of 0.16 quiz	0.18 quiz

Seems as if the option to manage resources in quizzes that have not been started was disabled altogether 🤨

nucleogenesis · 2025-03-10T23:35:12Z

kolibri/plugins/coach/assets/src/views/quizzes/QuizSummaryPage/QuizOptionsDropdownMenu.vue

@@ -41,7 +41,7 @@
          },
          { label: this.coreString('deleteAction'), value: 'DELETE' },
        ];
-        if (!this.exam?.archive) {
+        if (!this.exam?.data_model_version > 2) {


Looks like the ! here is making for the condition being the opposite of what is expected as we only want the editAction to show when the quiz is data_model_version > 2.

I think this is the cause of @radinamatic 's last report

github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jan 31, 2025

AllanOXDi requested review from nucleogenesis, akolson and AlexVelezLl January 31, 2025 19:58

AllanOXDi requested a review from radinamatic February 6, 2025 16:57

AllanOXDi commented Feb 6, 2025

View reviewed changes

AllanOXDi marked this pull request as ready for review February 6, 2025 17:05

AllanOXDi force-pushed the adds-notice-for-older-quizzes branch from 7f086c1 to 7a96110 Compare February 6, 2025 17:08

nucleogenesis self-assigned this Feb 11, 2025

nucleogenesis reviewed Feb 11, 2025

View reviewed changes

nucleogenesis requested changes Feb 11, 2025

View reviewed changes

akolson reviewed Feb 12, 2025

View reviewed changes

banner is dismissable

485a60a

AllanOXDi force-pushed the adds-notice-for-older-quizzes branch from f4637f5 to 485a60a Compare March 7, 2025 14:14

marcellamaki requested changes Mar 10, 2025

View reviewed changes

fixes variable naming

f7fd980

nucleogenesis reviewed Mar 10, 2025

View reviewed changes

remove the negation

0e1a072

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds notice for quizzes created pre-0.17.x #13045

adds notice for quizzes created pre-0.17.x #13045

AllanOXDi commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025 •

edited

Loading

AllanOXDi Feb 6, 2025

radinamatic Feb 7, 2025

AllanOXDi Feb 7, 2025

nucleogenesis Feb 11, 2025

nucleogenesis Feb 11, 2025

nucleogenesis Feb 11, 2025 •

edited

Loading

nucleogenesis left a comment

nucleogenesis Feb 11, 2025

radinamatic Feb 13, 2025

akolson Feb 12, 2025

akolson Feb 12, 2025

akolson Feb 12, 2025

AllanOXDi Feb 12, 2025

akolson left a comment

AllanOXDi commented Feb 12, 2025

radinamatic commented Feb 13, 2025 •

edited

Loading

AllanOXDi commented Feb 13, 2025

radinamatic commented Feb 13, 2025 •

edited

Loading

AllanOXDi commented Mar 7, 2025

marcellamaki left a comment

marcellamaki Mar 10, 2025

marcellamaki Mar 10, 2025

radinamatic commented Mar 10, 2025 •

edited

Loading

nucleogenesis Mar 10, 2025

adds notice for quizzes created pre-0.17.x #13045

Are you sure you want to change the base?

adds notice for quizzes created pre-0.17.x #13045

Conversation

AllanOXDi commented Jan 31, 2025 • edited Loading

Summary

References

Reviewer guidance

github-actions bot commented Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nucleogenesis Feb 11, 2025 • edited Loading

Choose a reason for hiding this comment

nucleogenesis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akolson left a comment

Choose a reason for hiding this comment

AllanOXDi commented Feb 12, 2025

radinamatic commented Feb 13, 2025 • edited Loading

AllanOXDi commented Feb 13, 2025

radinamatic commented Feb 13, 2025 • edited Loading

AllanOXDi commented Mar 7, 2025

marcellamaki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radinamatic commented Mar 10, 2025 • edited Loading

Choose a reason for hiding this comment

AllanOXDi commented Jan 31, 2025 •

edited

Loading

github-actions bot commented Jan 31, 2025 •

edited

Loading

nucleogenesis Feb 11, 2025 •

edited

Loading

radinamatic commented Feb 13, 2025 •

edited

Loading

radinamatic commented Feb 13, 2025 •

edited

Loading

radinamatic commented Mar 10, 2025 •

edited

Loading