Responder lifetime cannot be infered #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stackoverflow question shows that it's not sufficient to have elided lifetimes on
Responder
because these aren't correctly infered when the wrapped responder is less restrictive.The root cause of this is the
PhantomData
holding'r
and'o
insideResponder
. These aren't required because the bounds on the impl blocks are sufficient to provide the correct semantics, andR
will already hold these bounds implicitly.This is gonna be a breaking change, but it should make it easier to use in the long term. That is unless you can think of any cases that this doesn't handle?