Update to work with latest Rocket RC #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following changes were made:
- Satisfying the `#[must_use]` annotation on the `Rocket` struct where
necessary (mostly in test code)
- Adding the `http` crate for the `HeaderName` type
- Rocket no longer exports all of `hyper` or `http`
indescriminately, so we have to be more mindful of types from
either crate that we require. Thus, this commit adds the `http`
crate to satisfy the requirement.
- Updated tests to properly return a result from a launched `Rocket`
|
Thanks for this @ELD. LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were made:
#[must_use]annotation on theRocketstruct wherenecessary (mostly in test code)
httpcrate for theHeaderNametypehyperorhttpindescriminately, so we have to be more mindful of types from
either crate that we require. Thus, this commit adds the
httpcrate to satisfy the requirement.
Rocket