Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postgres): add geometry circle #3773

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

jayy-lmao
Copy link
Contributor

@jayy-lmao jayy-lmao commented Mar 8, 2025

Does your PR solve an issue?

Part 7 of fixing #166
fixes #166
(Breaking apart #3449)

Is this a breaking change?

No, it is adding a new type without changing or modifying existing types or features.

@jayy-lmao
Copy link
Contributor Author

With this one I decided also to format the links to the Postgres manual more consistently with the rest of the codebase.

@jayy-lmao
Copy link
Contributor Author

Also @abonander wondering if you want me to make the fixes to PgCube you mention inline before 9.0.0 as they'll breaking changes?

@abonander
Copy link
Collaborator

@jayy-lmao cube is from a different module entirely so I would consider it orthogonal to the addition of these geometry types.

If you'd like to do that work, I'd be grateful, though we should probably open an issue to discuss the changes. The big question is whether to keep it as an enum or make it an opaque type, because ultimately it can be represented as just a list of floats.

@abonander abonander merged commit 2f10c29 into launchbadge:main Mar 9, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support geometric types for postgres
2 participants