draft support for winansi encoding #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed the draft status, it's still only partial, in particular it ignores any So for now at least I've swiched https://texlive.net/showtags to use this branch |
davidcarlisle
commented
Feb 18, 2025
| ['\xFD'] = '\u{00FD}', | ||
| ['\xFE'] = '\u{00FE}', | ||
| ['\xFF'] = '\u{00FF}' | ||
| } |
There was a problem hiding this comment.
A0 to AF is in fact the identity so we could delete those entries and add that range to the range using the utf8.char function below (not sure which is simpler/faster)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zauguin apologise in advance for any horrors I've commited on your code...
I marked this as
draftas there are some parts I'm not happy with notably having to carry the encoding through by hand with a new enc field in thectx.current_fonttable. But as far as I can tell it does work and if a font has no toUnicode mapping outside the font data, but does have a known encoding (currently just "WinAnsi") then that mapping gets applied.This means that it shows text in more cases (only PDFUA-Ref-2-02_Invoice.xml in the pdf ref suite sadly) but Tagged-PDF-Best-Practice-Guide.pdf does better, as well as some other tests.
No pressure to merge this, but it's checked in so I don't lose it.