Skip to content

Fixing Slack Icon in Readme.Md #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

shettyvarshaa
Copy link
Contributor

@shettyvarshaa shettyvarshaa commented Oct 10, 2023

Fixing the broken Slack icon link which directs us to slack channel in README.md

Adding a "JOIN US ON SLACK" which directs us to slack channel
@github-actions
Copy link

Hi @shettyvarshaa! 👋

Thank you for submitting a pull request! We appreciate your contribution and will review your changes as soon as possible.

@larymak
Copy link
Owner

larymak commented Oct 11, 2023

Thanks for the fix.

@shettyvarshaa
Copy link
Contributor Author

Hello @larymak !
Why isn't the original link working? I'm new to this and I wanted to know if there is a way to fix this broken link which was already existing in the README.md without replacing the entire format of the slack icon itself as I did in my PR

Broken link : "https://raw.githubusercontent.com/netlify/netlify-cms/master/website/static/img/slack.png"

@larymak
Copy link
Owner

larymak commented Oct 12, 2023

Hello @larymak ! Why isn't the original link working? I'm new to this and I wanted to know if there is a way to fix this broken link which was already existing in the README.md without replacing the entire format of the slack icon itself as I did in my PR

Broken link : "https://raw.githubusercontent.com/netlify/netlify-cms/master/website/static/img/slack.png"

The link that's not working must be from the icon itself. It seems the maintainers of the icons no longer look after them

@shettyvarshaa
Copy link
Contributor Author

Oh I see, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants