improved overall script added new features #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LpCodes
commented
Mar 15, 2023
There was a problem hiding this comment.
this updated code uses secrets.choice() to generate random characters, which is a more secure method than using random.sample(). It also includes a main() function that encapsulates the code for generating passwords, making it more modular and easier to read. Finally, it includes error handling to ensure that the user inputs are valid integers.
|
Thanks for the detailed explanation given. Good job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved overall script by adding the following:
Added error handling: The script currently only checks for a FileNotFoundError. Added more error handling to handle different types of errors that may occur.
Added a way to output the results: Currently, the script prints the results to the console. Added an option to output the results to a file.
Added support for other operating systems: The script currently only works on Windows. Added support for other operating systems like macOS and Linux.
Added the ability to delete Wi-Fi profiles: Added a function to delete Wi-Fi profiles in case the user wants to remove saved profiles that they no longer use.