Added the missing 'trashed' event to getObservablesEvents() #55004
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes laravel#54980 Previous pull laravel#54987 but this one is more clear and inline.
|
No, only documentation for Observer should be updated to cover the different events available. |
|
So you are saying that this event should not be available in observers by default? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54980
I genuinely think this event was somehow forgot to be added there already.
Added the missing 'trashed' which gets registered with observers, so that observers too can listen to it besides listeners.
As per docs:
No breaking changes.
From the docs developers expect to listen to this event but if one uses observers then by default the observer would not be able catch it because it never was registered. This forced developers to redeclare the
$observablesin the model but this event belongs to the framework so it should not be missing by default from the already hard-coded event names array ingetObservablesEvents().No tests.