[12.x] Query builder PDO fetch modes + columns fix

[bert-w]

Same PR as #54443 , with the addition of a fix for #54708 + testcase.

The issue was caused by my assumption that pluck-arguments should override the $this->columns property in all situations. This however is not the case since you can do a:

$query->select(/* some-query AS my_column */)->pluck('my_column');

therefore requiring the custom named column. So the code to set the columns should remain:

$this->columns ??= ...

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[shaedrich]

Have you considered allowing to set the fetch mode via query() as I suggested in #54443 (comment)?

User::query(PDO::FETCH_UNIQUE)->select(['id','users.*'])->get();

[bert-w]

Have you considered allowing to set the fetch mode via query() as I suggested in #54443 (comment)?

User::query(PDO::FETCH_UNIQUE)->select(['id','users.*'])->get();

Yes I did; I dont think this is a feature that should be on the forefront that much so I thought a simple chained function would be better. Also when using DB::table('...') statements, there is no ->query()-> function anywhere so that might introduce some complexity. Same with how you can call User::where(...)->orderBy(...)->get() without ever having to use query().

A fetchUsing(...) is just the same across the board.

[shaedrich]

Yeah, that makes sense 👍🏻

Maybe, this can be additionally added as a convenience feature in a follow-up PR if it appears to be beneficial 🤔

[macropay-solutions]

@bert-w Same question as here #54443 (comment)

Will this work in Laravel 8-11 with onceWithColumns function with just ->fetchAll(...$fetchUsing) code (and related params) change?

[macropay-solutions]

@shaedrich

Yeah, that makes sense 👍🏻
Maybe, this can be additionally added as a convenience feature in a follow-up PR if it appears to be beneficial 🤔

That would need to be added in Laravel 13 as it would be a breaking change in the definition of the query function and of the subsequent functions called with that param.

[shaedrich]

Yeah, thanks for the hint 👍🏻