-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Store and ObjectRepository #2529
Merged
Merged
+275
−247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
2f956ed
to
9abbf32
Compare
9abbf32
to
a201aae
Compare
An interface named Repository is already exported from pluginContext.ts
|
rolljee
approved these changes
May 7, 2024
Kuruyia
approved these changes
May 7, 2024
🎉 This PR is included in version 2.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The purpose of this PR is to expose the internal
Store
andObjectRepository
Kuzzle classes in order to be able to use them in plugins to provide caching.Other changes
Store
to TypeScript.Repository
toObjectRepository
because of a conflictingRepository
interface being exported at https://github.com/kuzzleio/kuzzle/blob/2-dev/lib/core/plugin/pluginContext.ts#L62