Skip to content

etcd: Add unit test for release-3.5 branch #35011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

etcd: Add unit test for release-3.5 branch #35011

wants to merge 1 commit into from

Conversation

joshjms
Copy link
Member

@joshjms joshjms commented Jun 20, 2025 •
edited
Loading

Adding unit test postsubmits and periodics. Continuing #35000.

Ref: #32754

/cc @ivanvc @abdurrehman107

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. labels Jun 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshjms
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 20, 2025
@ivanvc ivanvc mentioned this pull request Jun 20, 2025
Open
15 tasks
ivanvc
ivanvc reviewed Jun 20, 2025
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Joshua. I'm just realizing that we forgot to add arm64 unit tests, too. I was reviewing the code from before we split that architecture into prow jobs, and we used to run arm64 unit tests, but forgot to migrate them.

Could you please enable arm64 in this pull request? Thanks :)

@joshjms
Copy link
Member Author

joshjms commented Jun 20, 2025

Ah I see, got it I'll add them

@joshjms joshjms changed the title etcd: Add unit test postsubmits and periodics for release-3.5 branch etcd: Add unit test for release-3.5 branch Jun 20, 2025
@joshjms joshjms force-pushed the etcd-unit-test-release-3.5 branch from ab0c6bc to 2ea9150 Compare June 20, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanvc ivanvc ivanvc left review comments

@abdurrehman107 abdurrehman107 Awaiting requested review from abdurrehman107

Assignees
No one assigned
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshjms @k8s-ci-robot @ivanvc