-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd: import grpcproxy presubmits #34297
etcd: import grpcproxy presubmits #34297
Conversation
|
||
- name: pull-etcd-grpcproxy-e2e | ||
optional: true # remove once the job is stable | ||
cluster: eks-prow-build-cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be running these tests on arm64
as well for parity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean parity with the prow jobs, right? Because we only had them running for AMD64 in the GitHub workflows.
I'll make the change, it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you suggest having pull-etcd-contrib-mixin
or pull-etcd-fuzzing-v3rpc
, multi-arch too?
939b5b6
to
3cc9c2d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold My last comment shouldn't affect the imported jobs. I can open up a new pull request later to address that thread. Thanks, @ahrtr. Edit: And for context, with James traveling, we may not have an answer soon, and I would like to continue working on finalizing the Prow migration. |
@ivanvc: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Imports the grpcproxy integration and e2e presubmit jobs.
Part of: #32754
/cc @jmhbnz @ahrtr