Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: import grpcproxy presubmits #34297

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Feb 7, 2025

Imports the grpcproxy integration and e2e presubmit jobs.

Part of: #32754

/cc @jmhbnz @ahrtr

@k8s-ci-robot k8s-ci-robot requested review from ahrtr and jmhbnz February 7, 2025 22:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 7, 2025

- name: pull-etcd-grpcproxy-e2e
optional: true # remove once the job is stable
cluster: eks-prow-build-cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be running these tests on arm64 as well for parity?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean parity with the prow jobs, right? Because we only had them running for AMD64 in the GitHub workflows.

I'll make the change, it makes sense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you suggest having pull-etcd-contrib-mixin or pull-etcd-fuzzing-v3rpc, multi-arch too?

@ivanvc ivanvc force-pushed the import-etcd-grpc-proxy-presubmit branch from 939b5b6 to 3cc9c2d Compare February 14, 2025 05:41
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2025
@ahrtr
Copy link
Member

ahrtr commented Feb 14, 2025

/lgtm
/approve

/hold

Please feel free to unhold it if both of you have no further comments. @ivanvc @jmhbnz

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@ivanvc
Copy link
Member Author

ivanvc commented Feb 14, 2025

/unhold

My last comment shouldn't affect the imported jobs. I can open up a new pull request later to address that thread.

Thanks, @ahrtr.

Edit: And for context, with James traveling, we may not have an answer soon, and I would like to continue working on finalizing the Prow migration.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3809243 into kubernetes:master Feb 14, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ivanvc: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

Imports the grpcproxy integration and e2e presubmit jobs.

Part of: #32754

/cc @jmhbnz @ahrtr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc deleted the import-etcd-grpc-proxy-presubmit branch February 14, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants