Deprecate config.yaml in testgrid #14937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
michelle192837
approved these changes
Oct 23, 2019
|
|
||
|
|
||
| NOTE: If you're adding a periodic or postsubmit and don't want to specially configure your test | ||
| group, you don't need to: [Configurator](/testgrid/cmd/configurator) implicitly assume a testgroup |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chases2, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Katharine
reviewed
Oct 23, 2019
|
|
||
| NOTE: If you're adding a periodic or postsubmit and don't want to specially configure your test | ||
| group, you don't need to: [Configurator](/testgrid/cmd/configurator) implicitly assume a testgroup | ||
| exists for all periodics and postsubmits. You still need to add presubmits here, and all jobs still |
There was a problem hiding this comment.
This is incorrect - you can and probably should just add an appropriate annotation to force it to be generated, unless you specifically need not to (which would apply equally to periodics and postsubmits).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves readme documentation to contain info that was in
config.yamlIncludes a deprecation notice in
config.yamlThis is part of an effort to shard testgrid's config, and should close #13541
/cc @michelle192837 @Katharine @spiffxp