fix: lowercase resources names #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AhmedGrati
requested review from
cdrage
and removed request for
sebgoa and
ngtuna
k8s-ci-robot
added
approved
AhmedGrati
force-pushed
the
fix-lowercase-resources-names
branch
from
60c9e55 to
709d39e
Compare
|
/lgtm |
k8s-ci-robot
added
lgtm
|
Needs rebase, once that is complete let's merge this in and I'll do a release this Friday, amazing work @AhmedGrati |
Signed-off-by: AhmedGrati <[email protected]>
AhmedGrati
force-pushed
the
fix-lowercase-resources-names
branch
from
709d39e to
b3774a4
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR aims to fix resource names. Previously, when the Compose service was capitalized, k8s resources names would be capitalized also, which would result in errors when trying to apply them. This PR aims to lowercase k8s resource names to reduce the amount of manual work that should be done by Kompose users.
Which issue(s) this PR fixes:
Fixes #1702