-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support for --profile cmd option #1709
Conversation
Welcome @axel7083! |
@cdrage To follow up on the message you post on podman-desktop/podman-desktop#3970 (comment) during my POC for a Kompose extension integrated in Podman Desktop I faced the issue of the docker-compose with profiles, that by default kompose ignore them. |
The code LGTM and implementation! But you'll have to add a test if that's okay for it to be all merged in :) |
I've added a test in the client. To do so, I added an example of docker-compose with some profile, and using the tool, I ensure it matches the expected output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One TINNYYYY change (no period at end of sentence and little bit of grammar change), but otherwise LGTM!
Co-authored-by: Charlie Drage <[email protected]>
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axel7083, cdrage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
When using docker compose we can use the profiles attribute.
In the current behaviour of kompose, if the compose file is using profiles, it will not process the services. This PR allows to add the
--profile
cmd command (repeatable) to send a list of string to the loader, that will be able to process the file and enable the services.Which issue(s) this PR fixes:
Fixes #1708 #1458 #1448
Special notes for your reviewer: