Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add read only containers support #1670

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Feat: add read only containers support #1670

merged 3 commits into from
Jul 16, 2023

Conversation

AhmedGrati
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support SecurityContext.ReadOnlyRootFileSystem through the docker_compose read_only attribute.

Which issue(s) this PR fixes:

Fixes #1668.

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cdrage and hangyan July 14, 2023 15:26
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2023
kundan2707
kundan2707 reviewed Jul 16, 2023
View reviewed changes
Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 071451d into kubernetes:main Jul 16, 2023
@cdrage
Copy link
Member

cdrage commented Jul 16, 2023

@kundan2707 Please only let code owners / maintainers use the LGTM. As it automatically merges the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kundan2707 kundan2707 kundan2707 left review comments

@cdrage cdrage Awaiting requested review from cdrage

@hangyan hangyan Awaiting requested review from hangyan

Assignees

@kundan2707 kundan2707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] read_only value in docker-compose not respected
5 participants
@AhmedGrati @k8s-ci-robot @cdrage @kundan2707 @TessaIO