-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump chart version to 4.1.2 #8607
Conversation
@mac-chaffee: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @mac-chaffee. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mac-chaffee thank you for the PR. One request. Can you check if any of those 3 PRs introduced a new parameter for values.yaml. If there was a new value, and if helmdocs was not run, can you check if you would need to run helmdocs https://github.com/kubernetes/ingress-nginx/blob/main/RELEASE.md#d-edit-the-valuesyaml-and-run-helm-docs locally, to generate a updated README.md under the /charts, and commit that updated README.md, from under the /charts (not in the root of the project), as well. Thank you in advance for this. |
Signed-off-by: Mac Chaffee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/ok-to-test |
Looks like the PR is missing a LGTM label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
let's move forward
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, mac-chaffee, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mac Chaffee <[email protected]>
Types of changes
Which issue/s this PR fixes
Didn't bump the version in #8587
How Has This Been Tested?
n/a
Checklist: