Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings in model-registry #2997

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mahdikhashan
Copy link
Member

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Describe the changes you have made, including any refactoring or feature additions.

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

🐛 Related Issues

Link any issues that are resolved or affected by this PR.

part of #2991

✅ Contributor Checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tomcli for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mahdikhashan mahdikhashan force-pushed the fix-manifest-warnings-model-registry branch from 03f4231 to 6ac01f8 Compare February 15, 2025 12:02
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Feb 15, 2025
@mahdikhashan
Copy link
Member Author

@juliusvonkohout i can not build the kustomization.yaml after using edit fix --vars command, it seems that the auto-fix could not find a parameter,

db:

Error: unable to find field "spec.template.spec.containers.1.args.1" in replacement target

postgres:

Warning: 'Fixed' kustomization now produces the error when running `kustomize build`: unable to find field "spec.template.spec.containers.0.args.2" in replacement target

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Feb 17, 2025

Can you try to do the changes directly here https://github.com/kubeflow/model-registry from where the manifests are synchronized from?

@mahdikhashan
Copy link
Member Author

Can you try to do the changes directly here https://github.com/kubeflow/model-registry from where the manifests are synchronized from?

yes, i'll do so. thank you.

@juliusvonkohout
Copy link
Member

can you please rebase both PRs ? so this one and kubeflow/model-registry#813 ?

@mahdikhashan
Copy link
Member Author

can you please rebase both PRs ? so this one and kubeflow/model-registry#813 ?

yes, ill do it tomorrow, hope it's fine with you.

@google-oss-prow google-oss-prow bot added size/M and removed size/L labels Mar 1, 2025
@mahdikhashan
Copy link
Member Author

can you please rebase both PRs ? so this one and kubeflow/model-registry#813 ?

done.

@juliusvonkohout
Copy link
Member

can you please rebase both PRs ? so this one and kubeflow/model-registry#813 ?

done.

And fix the tests with a zero diff ;-)

@mahdikhashan
Copy link
Member Author

can you please rebase both PRs ? so this one and kubeflow/model-registry#813 ?

done.

And fix the tests with a zero diff ;-)

sure. i'll do it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants