add JobFailedValidation reason constant #201
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
HeGaoYuan
force-pushed
the
issues1704
branch
from
6d5ee26 to
d274f47
Compare
| JobRestartingReason = "JobRestarting" | ||
| // JobFailedValidationReason is added in a job when it failed validation | ||
| JobFailedValidationReason = "JobFailedValidation" |
There was a problem hiding this comment.
Do we need this? Why not use JobFailedReason and put the right message?
There was a problem hiding this comment.
It depends on whether we set job to failed when we failed validation.
By the way, the state transition table of job status is not clear now.
|
@tenzen-y @terrytangyuan |
| // JobFailedValidationReason is added in a job when it failed validation | ||
| JobFailedValidationReason = "JobFailedValidation" |
There was a problem hiding this comment.
Once we introduce CEL validation, we will not use that status.
So, can you add a TODO comment with kubeflow/trainer#1708?
Yes, this status helps users to find a reason for errors. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add JobFailedValidation referring to kubeflow/trainer#1705