feat(debug): pprof debug version added to kubearmor #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemon1024
requested changes
Nov 14, 2023
PrimalPimmy
force-pushed
the
pporf
branch
2 times, most recently
from
50c4f2e to
5fd3798
Compare
|
Can we rebase the PR. Thanks. |
7 tasks
daemon1024
previously approved these changes
Feb 12, 2024
|
Please rebase again :D |
daemon1024
force-pushed
the
pporf
branch
2 times, most recently
from
e57e69f to
a7ffc2f
Compare
DelusionalOptimist
requested changes
Jun 27, 2024
KubeArmor/config/config.go
Outdated
| @@ -24,17 +24,19 @@ type KubearmorConfig struct { | |||
| TLSEnabled bool // enable tls | |||
| TLSCertPath string // tls certification path | |||
| TLSCertProvider string // tls certficate provider | |||
| PPROF string // pprof Port to use | |||
Co-authored-by: PrimalPimmy <[email protected]> Signed-off-by: PrimalPimmy <[email protected]> Signed-off-by: daemon1024 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Adds a PPROF debug version of Kubearmor to the dockerhub so that we can use that in various things like performance testing, without having to manually add it.
Fixes #1059 and rebased version of #1091
Does this PR introduce a breaking change?
no.
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>