Try out offficial prometheus_client
for metrics
#72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A working POC for prometheus/client_rust ripping out tikv/rust-prometheus. Not much easier than
measured
(via #71) because the documentation is lackluster, but the codebase ends up being slightly nicer (and proc macro stuff less confusing for sure).PROS:
CONS:
measured
's patterns manuallyString
This is not updated well enough that I would be comfortable using it. If it had working protobuf and maybe native histograms or something this would be worth talking about, but it's only really bringing some slight ergonomics + exemplars to the table, that's useless if they don't update depedendencies. We don't have to choose this. There's no major downside for using an unofficial metrics crate if offical upstream is just a collection of unoptimized structs putting
client
in its name to make itself seem important.