fix(types): Fix GetDependencies func that returns duplicate items

The iterator loop reuses item pointer which leads to duplicate of the
same dependencies while other dependencies are missing out.

Signed-off-by: Vu Dinh <[email protected]>

Author: dinhxuanvu

bundles/prometheus.0.22.2/metadata/dependencies.yaml

@@ -2,3 +2,7 @@ dependencies:
   - type: olm.package
     packageName: testoperator
     version: "> 0.2.0"
+  - type: olm.gvk
+    group: testprometheus.coreos.com
+    kind: testtestprometheus
+    version: v1

pkg/registry/populator_test.go

@@ -428,6 +428,10 @@ func TestQuerierForDependencies(t *testing.T) {
 			Type:  "olm.gvk",
 			Value: `{"group":"etcd.database.coreos.com","kind":"EtcdCluster","type":"olm.gvk","version":"v1beta2"}`,
 		},
+		{
+			Type:  "olm.gvk",
+			Value: `{"group":"testprometheus.coreos.com","kind":"testtestprometheus","type":"olm.gvk","version":"v1"}`,
+		},
 	}
 
 	type operatorbundle struct {
@@ -484,6 +488,10 @@ func TestListBundles(t *testing.T) {
 			Type:  "olm.gvk",
 			Value: `{"group":"etcd.database.coreos.com","kind":"EtcdCluster","type":"olm.gvk","version":"v1beta2"}`,
 		},
+		{
+			Type:  "olm.gvk",
+			Value: `{"group":"testprometheus.coreos.com","kind":"testtestprometheus","type":"olm.gvk","version":"v1"}`,
+		},
 	}
 
 	dependencies := []*api.Dependency{}

pkg/registry/types.go

@@ -196,7 +196,8 @@ func (pd *PackageDependency) Validate() []error {
 func (d *DependenciesFile) GetDependencies() []*Dependency {
 	var dependencies []*Dependency
 	for _, item := range d.Dependencies {
-		dependencies = append(dependencies, &item)
+		dep := item
+		dependencies = append(dependencies, &dep)
 	}
 	return dependencies
 }