Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-1312): change FBC e2e tests back to build a image #1506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jinqi7
Copy link
Contributor

@jinqi7 jinqi7 commented Feb 12, 2025

  • Added two functions CreateComponentWithNewBranch and CreatePushSnapshot
    to build a new image and trigger the managed pipelineRun.
  • Updated four FBC test cases to use the functions and delete the test
    branches created for testing.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Feb 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jinqi7. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jinqi7 jinqi7 marked this pull request as ready for review February 12, 2025 06:14
@jinqi7
Copy link
Contributor Author

jinqi7 commented Feb 12, 2025

/retest

@jinqi7 jinqi7 force-pushed the RELEASE_1312 branch 4 times, most recently from f40de0a to 292eb03 Compare February 12, 2025 07:13
@jinqi7
Copy link
Contributor Author

jinqi7 commented Feb 12, 2025

/retest

1 similar comment
@jinqi7
Copy link
Contributor Author

jinqi7 commented Feb 13, 2025

/retest

@jinqi7 jinqi7 force-pushed the RELEASE_1312 branch 2 times, most recently from 90a06e4 to de927d3 Compare February 13, 2025 04:26
@jinqi7
Copy link
Contributor Author

jinqi7 commented Feb 13, 2025

/retest

1 similar comment
@jinqi7
Copy link
Contributor Author

jinqi7 commented Feb 13, 2025

/retest

@jinqi7 jinqi7 force-pushed the RELEASE_1312 branch 2 times, most recently from e753a01 to 1db9a80 Compare February 13, 2025 12:56
@jinqi7 jinqi7 requested a review from a team February 13, 2025 13:00
Signed-off-by: Jing Qi <[email protected]>

Added two functions CreateComponentWithNewBranch and CreatePushSnapshot
 to build a new image and trigger the managed pipelineRun.
Updated four FBC test cases to use the functions and delete the test
branches created for testing.
@jinqi7
Copy link
Contributor Author

jinqi7 commented Feb 14, 2025

/retest

@jinqi7 jinqi7 requested a review from psturc February 18, 2025 10:11
@jinqi7 jinqi7 requested a review from a team February 26, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants