Switch build system from Maven to Gradle #789
Conversation
|
@simonpoole If you have a minute to spare, I'd appreciate a quick look from a long-term user of gradle. |
|
Will give it a look ASAP. |
|
Changes look fine to me. I ran a build on my laptop, and outside of some of the tests failing (likely because of windows issues), that looked fine too. |
| </manifestEntries> | ||
| </transformer> | ||
| <transformer | ||
| implementation="org.apache.logging.log4j.maven.plugins.shade.transformer.Log4j2PluginCacheFileTransformer" /> |
There was a problem hiding this comment.
That one is missing in the gradle version
There was a problem hiding this comment.
The only replacement I can find is a very old plugin that hasn't been touched since 2018. Any other suggestions for replacements?
There was a problem hiding this comment.
The log4j2 support for Gradle seems to be lacking apache/logging-log4j-transform#73
I think we can skip it as long as we don't have multiple log4j2 plugins. Otherwise we get problems with conflicting Log4j2Plugins.dat files.
There was a problem hiding this comment.
OK, I'll leave it then. It seems to be compiling and running as is.
Thanks for looking and thanks for the review.
There was a problem hiding this comment.
Note to self: found the proper way to solve this. Add
transform(com.github.jengelman.gradle.plugins.shadow.transformers.Log4j2PluginsCacheFileTransformer)
to shadow step.
There was a problem hiding this comment.
Log4j2PluginsCacheFileTransformer may not work, I'm fixing it in GradleUp/shadow#1175.
I hope that Gradle offers a bit more flexibility in creating jars with different configurations. And even if not, it is a huge improvement in terms of readability of the build file and availability of documentation.