Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CM Cert reconcile and deletion if feature is turned off #8519

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

matzew
Copy link
Member

@matzew matzew commented Mar 11, 2025

Fixes #

Proposed Changes

  • Improve CM Cert reconcile and deletion if feature is turned off

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2025
@knative-prow knative-prow bot requested review from aliok and lionelvillard March 11, 2025 12:52
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (ebd149e) to head (58582a2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/integration/sink/integrationsink.go 58.33% 19 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8519      +/-   ##
==========================================
+ Coverage   52.38%   52.43%   +0.04%     
==========================================
  Files         397      397              
  Lines       24836    24869      +33     
==========================================
+ Hits        13011    13039      +28     
- Misses      11038    11043       +5     
  Partials      787      787              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matzew matzew force-pushed the refine_cert_reconcilation branch from c8b6263 to 58582a2 Compare March 11, 2025 13:22
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
Copy link

knative-prow bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6ffe7c1 into knative:main Mar 11, 2025
35 of 36 checks passed
@matzew matzew deleted the refine_cert_reconcilation branch March 11, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants