Skip to content

feat(KC): justification + small fixes #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2022
Merged

feat(KC): justification + small fixes #90

merged 6 commits into from
Jun 16, 2022
+195 −114

Conversation

unknownunknown1
Copy link
Contributor

Added features:

  1. Unstaking of ineligible jurors
  2. Justification of the vote
  3. Safe transfers to avoid reverts
  4. 1 vote per address in PoH DK
  5. Changing the default court to General instead of Forking. The latter is basically rudimental now. I need clarifications on how to implement the forking process
  6. Some small fixes along the way

@unknownunknown1
feat(KC): justification + small fixes

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 6B88202C3FD069DD
Learn about vigilant mode
732847e
@netlify
Copy link

netlify bot commented Jun 13, 2022 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit f66ab4b
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/62a99e4b01fe3b00096a4b5e
😎 Deploy Preview https://deploy-preview-90--kleros-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@unknownunknown1 unknownunknown1 requested a review from jaybuidl June 13, 2022 06:39
@jaybuidl jaybuidl added this to the prealpha-3 milestone Jun 13, 2022
@jaybuidl
Copy link
Member

We could add the _justification as part of the commitment hash? L330

@unknownunknown1
feat(DK): add justitication to commit

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 6B88202C3FD069DD
Learn about vigilant mode
2947180
@unknownunknown1
fix(KC): createTree bug

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 6B88202C3FD069DD
Learn about vigilant mode
75c9510
@unknownunknown1
fix(KC): test file fix

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 6B88202C3FD069DD
Learn about vigilant mode
333169d
@unknownunknown1
style(test): remove empty lines

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 6B88202C3FD069DD
Learn about vigilant mode
51ec1d2
@unknownunknown1
feat(KC): remove unstaking feature

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 6B88202C3FD069DD
Learn about vigilant mode
f66ab4b
@codeclimate
Copy link

codeclimate bot commented Jun 15, 2022

Code Climate has analyzed commit f66ab4b and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
88.9% 88.9% Duplication

@jaybuidl jaybuidl merged commit 10ad99b into kleros:master Jun 16, 2022
@jaybuidl jaybuidl added the Compatibility: ABI change 🗯 Smart contract ABI is changing. label Aug 8, 2022
Params10 pushed a commit that referenced this pull request Feb 3, 2023
@jaybuidl
Merge pull request #90 from unknownunknown1/small-features
d0b887e 
feat(KC): justification + small fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaybuidl jaybuidl

Assignees

@unknownunknown1 unknownunknown1

Labels
Compatibility: ABI change 🗯 Smart contract ABI is changing. Type: Feature🗿
Projects
None yet
Milestone
prealpha-3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@unknownunknown1 @jaybuidl