Skip to content

Feat: Add getTimesPerPeriod to KlerosCore #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

alcercu
Copy link
Contributor

@alcercu alcercu commented Feb 17, 2022

This getter was needed to access timesPerPeriod array for a given court since the default getter generated for public variables by the solidity compiler does not include arrays.

@alcercu alcercu requested a review from jaybuidl February 17, 2022 18:17
@codeclimate
Copy link

codeclimate bot commented Feb 17, 2022

Code Climate has analyzed commit c06d707 and detected 0 issues on this pull request.

View more on Code Climate.

@jaybuidl jaybuidl added this to the prealpha-1 milestone Feb 17, 2022
@jaybuidl jaybuidl merged commit d1b32b6 into master Feb 17, 2022
@jaybuidl jaybuidl deleted the feat/add-getTimesPerPeriods branch February 17, 2022 18:30
jaybuidl added a commit that referenced this pull request Feb 18, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
jaybuidl added a commit that referenced this pull request Feb 18, 2022

Verified

This commit was signed with the committer’s verified signature.
jaybuidl jaybuidl
@jaybuidl jaybuidl restored the feat/add-getTimesPerPeriods branch November 24, 2022 02:59
@jaybuidl jaybuidl deleted the feat/add-getTimesPerPeriods branch November 24, 2022 03:09
Params10 pushed a commit that referenced this pull request Feb 3, 2023

Verified

This commit was signed with the committer’s verified signature.
jaybuidl jaybuidl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants