Skip to content

fix: voting-results-and-display #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2023
Merged

fix: voting-results-and-display #1108

merged 5 commits into from
Aug 7, 2023

Conversation

nhestrompia
Copy link
Contributor

Fixes #1085 and other edge cases with disputeTemplate

@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 1c8db72
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/64d0cbde93168c00082cd401
😎 Deploy Preview https://deploy-preview-1108--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2-contracts ready!

Name Link
🔨 Latest commit 1c8db72
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/64d0cbdec47d820008f10bb1
😎 Deploy Preview https://deploy-preview-1108--kleros-v2-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Aug 7, 2023

Code Climate has analyzed commit 1c8db72 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 6

View more on Code Climate.

@alcercu alcercu changed the base branch from dev to staging-web August 7, 2023 15:22
alcercu
alcercu requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see getChoiceText and getVoteChoice are quite similar, could we abstract that function?

alcercu
alcercu approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu merged commit 5be2a1f into staging-web Aug 7, 2023
@alcercu alcercu deleted the fix(web)/voting-results-and-display branch August 7, 2023 16:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaybuidl jaybuidl added Type: Bug 🐛 Package: Web Court web frontend labels Aug 8, 2023
@jaybuidl jaybuidl added this to the alpha-testnet milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees
No one assigned
Labels
Package: Web Court web frontend Type: Bug 🐛
Projects
None yet
Milestone
testnet-1
Development

Successfully merging this pull request may close these issues.

Voting history: show the history component during voting period
3 participants
@nhestrompia @alcercu @jaybuidl