-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added API endpoint for apportionment #921
Conversation
… election summary
Sigrid maintainability feedback✅ You wrote maintainable code and achieved your objective of 3.5 stars Show detailsSigrid compared your code against the baseline of 2025-01-30. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid** to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
Bundle ReportChanges will increase total bundle size by 509 bytes (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: abacus-frontend-esmAssets Changed:
Files in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a few questions as comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Is see that a lot of fully qualified names are moved to use
imports, sometimes put behind a feature flag. Personally I think there is nothing wrong with using the fully qualified name in the code. Sometimes it help with ubiquitous terms like Client
. Readability obviously shouldn't suffer though.
Co-authored-by: Marlon Peeters <[email protected]>
Description
data_entry
parameter for easier testingelection_id
parameter to sharedcreate_result
function to be able to use it for different electionsresponse.status()
testing to be the same in all tests (asserting with equality toStatusCode::
)