[BUGFIX] Fixes the isComputed check for beta #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In beta, `computed` now returns a decorator function instead of a ComputedProperty instance (ComputedProperty is now internal only). This changes the check to be against a function, and to see if it has the `_getter` property that we still expose for the time being.
|
Any update on this? Seems a bunch of tests are still failing... I believe I just ran into this after upgrading to latest canary. For something like this: I get a "Brace expanded properties cannot contain spaces..." assertion, as the CP's key is |
|
Should be fixed in #260. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In beta,
computednow returns a decorator function instead ofa ComputedProperty instance (ComputedProperty is now internal only).
This changes the check to be against a function, and to see if it
has the
_getterproperty that we still expose for the time being.This depends on emberjs/ember.js#17855