Downgrade Go version requirement to 1.20 #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the upgrade to Go 1.21, the Go toolchain now requires the `go` directive to match the maximum Go version in use in dependencies. This leads to any transitive dependency on this library to result in a requirement of the consuming project moving to Go 1.21. Although in a lot of cases this may not be as problematic, it forces consumers to migrate, which we don't need to do in this case. This also requires we bump jwt and httpexpect dependencies, as they've downgraded, too.
|
|
kataras
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
I always prefer to use the latest versions to my projects in order to force our developers to upgrade to the latest Go version if they want to upgrade to the latest Iris version. Every single new Go release comes with new security fixes and that's why I prefer latest updates. However, I see that this decision is kind of problematic for you so I am happy to accept and merge this PR. Thank you @jamietanna
|
Thanks very much @kataras 🙌 Would you be OK to push a release when you get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the upgrade to Go 1.21, the Go toolchain now requires the
godirective to match the maximum Go version in use in dependencies.This leads to any transitive dependency on this library to result in a
requirement of the consuming project moving to Go 1.21.
Although in a lot of cases this may not be as problematic, it forces
consumers to migrate, which we don't need to do in this case.
This also requires we bump jwt and httpexpect dependencies, as they've
downgraded, too.
As discussed in oapi-codegen/oapi-codegen#1221 and related change in gofiber/fiber#2614. See also golang/go#62409
Draft until below are merged: