Fix potential pointer math truncation and improve readability #551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix potential pointer math truncation bug. Improve readability of datatypes when binary length or handling is at play.
*data + sizeof(Config)/sizeof(float);
could can been fractional and thus truncated, leading to an incorrect pointer. Admittedly rare given the pointer padding, but given how people depend on llama2.c as a canonical learning resource, it should be fixed.int
andunsigned long long
int
, unlocking the full range of possible seeds rather than just those up to2^31-1