Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes #4

Merged
merged 8 commits into from
Apr 15, 2020
Merged

More fixes #4

merged 8 commits into from
Apr 15, 2020

Conversation

lolmaus
Copy link
Contributor

@lolmaus lolmaus commented Apr 5, 2020

Regarding build failure with floating dependencies: this seems to be an issue upstream:
emberjs/ember.js#18831

@lolmaus lolmaus requested review from nickschot and simonihmig April 5, 2020 13:04
@simonihmig
Copy link
Member

Regarding build failure with floating dependencies: this seems to be an issue upstream

Yes, had to fix this in a few of our addons. Upgrading to Ember 3.16 should do it!

@simonihmig
Copy link
Member

@lolmaus I added one commit here, that should fix the remaining build error. Was caused by a linting error in .ember-cli.js. But the changes to that file have been reverted in the ember-cli blueprint itself. Seems ember-cli-update did not catch this. So this commit does the same revert, making the file again match the official blueprint (see https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/.ember-cli)

When this is green, we should merge it.

@simonihmig simonihmig merged commit 94189cc into master Apr 15, 2020
@simonihmig simonihmig deleted the fixes-2 branch April 15, 2020 12:23
@lolmaus
Copy link
Contributor Author

lolmaus commented Apr 15, 2020

Yay, thanks for looking into this!

@simonihmig simonihmig added the bug Something isn't working label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants