Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File explorer popup #73

Merged
merged 32 commits into from
Feb 4, 2021
Merged

File explorer popup #73

merged 32 commits into from
Feb 4, 2021

Conversation

jwlodek
Copy link
Owner

@jwlodek jwlodek commented Dec 30, 2020 •
edited
Loading

Quick summary of pull request...

  • I have read the contribution guidelines
  • CI Unit tests pass
  • New functions/classes have consistent docstrings

What this pull request changes

  • Version for packaging pulled from library
  • New popup added - file explorer. Allows for selecting file/dir/saveas location
  • Fix issue introduced to focus border color option
  • New example + example cleanup
  • Some internal naming changes to improve readability

Issues fixed with this pull request

Optionally, what changes should join this PR

  • Updated documentation
  • New screenshots?

jwlodek and others added 21 commits October 29, 2020 15:26
@jwlodek
Have version in setup file pull from library
f8d6e31
@jwlodek
Started working on file explorer widget/popup
f8e7e36
@jwlodek
FileDialog popup somewhat displays, but incorrectly now
2371948
@jwlodek
Starting to look as it should
987fea8
@jwlodek
Make sure focus_border_color is set correctly for popups
6b795d1
@jwlodek
Set focus border color if same color is used for all widget elements.
b81e6b8
@jwlodek
File explorer widget coming along - visuals mostly working
4827a91
@jwlodek
Working on hidden file and extension based handling
9807ac4
@jwlodek
Updating with auto-created docstrings via code2npdoc
5788fdb
@jwlodek
Continue to work on file dialog
29ee0d0
@jwlodek
Fix kwarg errors
1f914b4
@jwlodek
Delete unnecessary file
f66a1f2
@jwlodek
Better respond to different dialog types
a347bc4
@jwlodek
Refactor to simplify repeated code, better handle submissions
a387a1b
Merge branch 'file-explorer-widget' of https://github.com/jwlodek/py_cui
bd5ffd1 
 into file-explorer-widget
Renamed some files/modules
8670c57
Add demo program for filedialog popup
fae87cb
Fixes for issues introduced with renaming
0ef4cb0
Fix failing test, tidy up filedialog example, simplify submitting ope…
48d9879 
…nfile popup
Fix Home/End keys for filedialog input box
ad9b0ab
Minor updates to examples, docstring updates, formatting
f7606b2
@jwlodek jwlodek changed the title File explorer widget [FEATURE] File explorer popup Dec 30, 2020
@jwlodek jwlodek changed the title [FEATURE] File explorer popup File explorer popup Dec 30, 2020
@jwlodek jwlodek added Examples Add for issues having to do with examples Feature Request Add for a new feature request Popups Add for issues having to do with popups labels Dec 30, 2020
@jwlodek jwlodek added this to the v0.1.3 milestone Dec 30, 2020
@jwlodek
Copy link
Owner Author

jwlodek commented Jan 21, 2021

Using ascii_icons=False on windows breaks rendering of widgets due to #85

@jwlodek jwlodek marked this pull request as ready for review February 4, 2021 22:11
@jwlodek jwlodek merged commit b4938dd into master Feb 4, 2021
@jwlodek jwlodek deleted the file-explorer-widget branch March 4, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Examples Add for issues having to do with examples Feature Request Add for a new feature request Popups Add for issues having to do with popups
Projects
None yet
Milestone
v0.1.3
Development

Successfully merging this pull request may close these issues.
1 participant
@jwlodek