Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small modifications to handle exit_key set to None. #122

Merged
merged 1 commit into from
May 26, 2021
Merged

Small modifications to handle exit_key set to None. #122

merged 1 commit into from
May 26, 2021

Conversation

PabloLec
Copy link
Contributor

@PabloLec PabloLec commented May 26, 2021

PyCUI main object exit_key can now be set to None.

What this pull request changes

Code modifications are:

  • Catching None value and returning None in get_char_from_ascii() function.
  • An if-statement in __init__.py to adapt _init_status_bar_text if there is no exit key.

Main draw loop has not been modified and I think this should not be a problem since default "empty" key value is 0 and not None.
I did some testing with basic examples and the key integration seems to work as expected.

Issues fixed with this pull request

@jwlodek jwlodek merged commit 1c601a2 into jwlodek:v0.1.4-develop May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants