Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transforming objects when clipping is enabled #565

Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Nov 6, 2024

This is done by having two transform controls, one specific to the clip plane, one specific to moving objects in the scene.

Screencast.From.2024-11-06.17-37-00.mp4

@martinRenou martinRenou requested a review from arjxn-py November 6, 2024 16:37
@martinRenou martinRenou added the enhancement New Feature or improvement label Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Integration tests report: appsharing.space

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Preview PR at appsharing.space

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinRenou, this looks so good.
Love it 🚀

@arjxn-py arjxn-py merged commit 4048066 into jupytercad:main Nov 6, 2024
10 of 12 checks passed
@martinRenou martinRenou deleted the allow_transforming_object_with_clipping branch November 6, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants