Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main logo #520

Merged
merged 2 commits into from
Oct 22, 2024
+45 −20
Merged

Update main logo #520

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3613580
Update main icon
martinRenou Oct 22, 2024
9b54fab
Fix icon selection in the file browser
martinRenou Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Fix icon selection in the file browser
@martinRenou
martinRenou committed Oct 22, 2024

Verified

This commit was signed with the committer’s verified signature.
radoering Randy Döring
GPG key ID: AE3FC76D748EA36F
Verified
Learn about vigilant mode
commit 9b54faba6f8ce44cdbc0920bbb4714726364d849
15 changes: 10 additions & 5 deletions packages/base/style/icon/logo.svg
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

Unchanged files with check annotations Beta

View file
ui-tests/tests/ui.spec.ts
import { expect, test, galata } from '@jupyterlab/galata';

Check failure on line 1 in ui-tests/tests/ui.spec.ts

GitHub Actions / Integration tests

tests/ui.spec.ts:51:11 › UI Test › File operations › Should be able to render 3M_CONNECTOR.STEP without error 

  1) tests/ui.spec.ts:51:11 › UI Test › File operations › Should be able to render 3M_CONNECTOR.STEP without error 
    Test timeout of 60000ms exceeded.
import path from 'path';
test.use({ autoGoto: false });
await page
.getByRole('tablist', { name: 'main sidebar' })
.getByRole('tab', { name: 'JupyterCad Control Panel' })
.click();

Check failure on line 66 in ui-tests/tests/ui.spec.ts

GitHub Actions / Integration tests

tests/ui.spec.ts:51:11 › UI Test › File operations › Should be able to render 3M_CONNECTOR.STEP without error 

  1) tests/ui.spec.ts:51:11 › UI Test › File operations › Should be able to render 3M_CONNECTOR.STEP without error 
    Error: locator.click: Test timeout of 60000ms exceeded.
    Call log:
      - waiting for getByRole('tablist', { name: 'main sidebar' }).getByRole('tab', { name: 'JupyterCad Control Panel' })
      -   locator resolved to <li role="tab" tabindex="-1" id="tab-key-1-6" aria-selected="true" title="JupyterCad Control Panel" class="lm-TabBar-tab lm-mod-current" data-id="jupytercad::leftControlPanel">…</li>
      - attempting click action
      -   waiting for element to be visible, enabled and stable
      -   element is visible, enabled and stable
      -   scrolling into view if needed
      -   done scrolling
      -   <dialog aria-modal="true" class="lm-Widget jp-Dialog" aria-label="File Load Error for 3M_CONNECTOR.STEP Unexpected token 'I', "ISO-10303-"... is not valid JSON">…</dialog> intercepts pointer events
      - retrying click action, attempt #1
      -   waiting for element to be visible, enabled and stable
      -   element is visible, enabled and stable
      -   scrolling into view if needed
      -   done scrolling
      -   <dialog aria-modal="true" class="lm-Widget jp-Dialog" aria-label="File Load Error for 3M_CONNECTOR.STEP Unexpected token 'I', "ISO-10303-"... is not valid JSON">…</dialog> intercepts pointer events
      - retrying click action, attempt #2
      -   waiting 20ms
      -   waiting for element to be visible, enabled and stable
      -   element is visible, enabled and stable
      -   scrolling into view if needed
      -   done scrolling
      -   <dialog aria-modal="true" class="lm-Widget jp-Dialog" aria-label="File Load Error for 3M_CONNECTOR.STEP Unexpected token 'I', "ISO-10303-"... is not valid JSON">…</dialog> intercepts pointer events
      - retrying click action, attempt #3
      -   waiting 100ms
      -   waiting for element to be visible, enabled and stable
      -   element is visible, enabled and stable
      -   scrolling into view if needed
      -   done scrolling
      -   <dialog aria-modal="true" class="lm-Widget jp-Dialog" aria-label="File Load Error for 3M_CONNECTOR.STEP Unexpected token 'I', "ISO-10303-"... is not valid JSON">…</dialog> intercepts pointer events
      - retrying click action, attempt #4
      -   waiting 100ms
      -   waiting for element to be visible, enabled and stable
      -   element is visible, enabled and stable
      -   scrolling into view if needed
      -   done scrolling
      -   <dialog aria-modal="true" class="lm-Widget jp-Dialog" aria-label="File Load Error for 3M_CONNECTOR.STEP Unexpected token 'I', "ISO-10303-"... is not valid JSON">…</dialog> intercepts pointer events
      - retrying click action, attempt #5
      -   waiting 500ms
      -   waiting for element to be visible, enabled and stable
      -   element is visible, enabled and stable
      -   scrolling into view if needed
      -   done scrolling
      -   <dialog aria-modal="true" class="lm-Widget jp-Dialog" aria-label="File Load Error for 3M_CONNECTOR.STEP Unexpected token 'I', "ISO-10303-"... is not valid JSON">…</dialog> intercepts pointer events
      - retrying click action, attempt #6
      -   waiting 500ms
      -   waiting for element to be visible, enabled and stable
      -   element is visible, enabled and stable
      -   scrolling into view if needed
      -   done scrolling
      -   <dialog aria-modal="true" class="lm-Widget jp-Dialog" aria-label="File Load Error for 3M_CONNECTOR.STEP Unexpected token 'I', "ISO-10303-"... is not valid JSON">…</dialog> intercepts pointer events
      - retrying click action, attempt #7
      -   waiting 500ms
      -   waiting for element to be visible, enabled and stable
      -   element is visible, enabled and stable
      -   scrolling into view if needed
      -   done scrolling
      -   <dialog aria-modal="true" class="lm-Widget jp-Dialog" aria-label="File Load Error for 3M_CONNECTOR.STEP Unexpected token 'I', "ISO-10303-"... is not valid JSON">…</dialog> intercepts pointer events
      - retryi
await page
.getByRole('tablist', { name: 'alternate sidebar' })
.getByRole('tab', { name: 'JupyterCad Control Panel' })
await page
.locator('[data-test-id="react-tree-root"]')
.getByText('box2')
.click();

Check failure on line 159 in ui-tests/tests/ui.spec.ts

GitHub Actions / Integration tests

tests/ui.spec.ts:148:9 › UI Test › File operator test › Should be able to remove object 

  2) tests/ui.spec.ts:148:9 › UI Test › File operator test › Should be able to remove object ───────
    Error: locator.click: Error: strict mode violation: locator('[data-test-id="react-tree-root"]').getByText('box2') resolved to 2 elements:
        1) <span>box2</span> aka getByText('box2').first()
        2) <span>box2</span> aka getByText('box2').nth(1)

    Call log:
      - waiting for locator('[data-test-id="react-tree-root"]').getByText('box2')


      157 |         .locator('[data-test-id="react-tree-root"]')
      158 |         .getByText('box2')
    > 159 |         .click();
          |          ^
      160 |       await page
      161 |         .locator('[data-test-id="react-tree-root"]')
      162 |         .getByRole('button')

        at /home/runner/work/JupyterCAD/JupyterCAD/ui-tests/tests/ui.spec.ts:159:10
await page
.locator('[data-test-id="react-tree-root"]')
.getByRole('button')
await page
.locator('[data-test-id="react-tree-root"]')
.getByText('box2')
.click();

Check failure on line 202 in ui-tests/tests/ui.spec.ts

GitHub Actions / Integration tests

tests/ui.spec.ts:190:9 › UI Test › File operator test › Should be able to edit object 

  3) tests/ui.spec.ts:190:9 › UI Test › File operator test › Should be able to edit object ─────────
    Error: locator.click: Error: strict mode violation: locator('[data-test-id="react-tree-root"]').getByText('box2') resolved to 2 elements:
        1) <span>box2</span> aka getByText('box2').first()
        2) <span>box2</span> aka getByText('box2').nth(1)

    Call log:
      - waiting for locator('[data-test-id="react-tree-root"]').getByText('box2')


      200 |         .locator('[data-test-id="react-tree-root"]')
      201 |         .getByText('box2')
    > 202 |         .click();
          |          ^
      203 |       await page
      204 |         .locator('[data-test-id="react-tree-root"]')
      205 |         .getByText('Shape')

        at /home/runner/work/JupyterCAD/JupyterCAD/ui-tests/tests/ui.spec.ts:202:10
await page
.locator('[data-test-id="react-tree-root"]')
.getByText('Shape')