-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exaggerate clip plane size #490
Conversation
Preview PR at appsharing.space |
Integration tests repot: appsharing.space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super 🚀
Thanks @martinRenou
How do you turn these controls to the sphere thing? That's soo coool |
Could this be computed base on the e.g. the bounding box of the whole jcad document, or would that be too expensive? (I guess bounding boxes of individual objects could be cached) |
|
That's the "R" keyboard shortcut :) |
By the way, testing out this morning, I see that I'm looking into it. Multiplying by 1000 here still makes sense, we just want to make sure the plane is bigger, if I could make an infinite plane I would. |
Is this still required after #493? (just reacting to the magicall x1000 constant, which might not even be good if one uses a completely different unit...) |
I'm not sure why you're saying it might not be good? |
What we need is an infinite plane, but there is no such thing in WebGL. Multiplying the reflength by a big number allows us to make sure the size of the plane is big enough to cover the shapes. |
The clipplane mesh is not fully filling the gap left by the clipping effect. This PR fixes it.
Before:
Screencast.from.2024-10-16.20-46-22.mp4
After:
Screencast.from.2024-10-16.20-44-32.mp4