Button to Center view on visible objects #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview PR at appsharing.space |
|
Integration tests repot: appsharing.space |
trungleduc
reviewed
Oct 7, 2024
trungleduc
reviewed
Oct 7, 2024
trungleduc
previously requested changes
Oct 7, 2024
|
Neat! Can you show a screencast of the feature? |
Sure: center.mov |
martinRenou
reviewed
Oct 8, 2024
trungleduc
reviewed
Oct 9, 2024
martinRenou
force-pushed
the
center-view
branch
from
30b1f58 to
4bd6b28
Compare
|
Looks like this PR is angry and requires review from @trungleduc again since he requested changes? |
SylvainCorlay
dismissed
trungleduc’s stale review
It seems that the review comment was addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #127
center.mov