Remove Streams in Sneak/Interact Events #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streams have very poor overall performance, and are especially rough to use in hot code. Players sneak and Interact constantly, and at scale, usage of streams here was causing up to 1.5% of my server's tick with around 1400+ NPCs in the
npcMap.Simple for-loops are generally best performance. In addition, I reordered the checks to be the most performant (boolean check, then equals check, reserving map lookup for
isShownForand finally distance check for last). After these changes, I didn't even see the events show up in my profiler.In my personal case, we don't even use imitating NPCs, so the best possible performance here would really be to cache into a separate map only the NPCs that imitate, but that might be a micro-optimization for most use cases unless people have thousands and thousands of NPCs.