-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Norwegian translation #201
Conversation
Hmm, complicated. From the ISO side, no – inclusive code But I'm not sure how Android maps those. |
CI is failing, there's some issues in the xml. Please push updates and keep a look on the CI report here. |
The CI report claims that a "resources" element is unclosed, despite how I can see that it indeed is closed (Lines 1 and 108 in the strings.xml). It's written in the Bokmål standard, which rules out "nn". While I presume that both "no" and "nb" can be used, I suppose you could use "nb" for safety's sake? |
I have not tried it, but maybe I could just symlink values-no and values-nn to values-nb in the meantime, so there's no fallback to English. |
Here's the problem:
You are closing string twice, and it now matches the |
Seeing if removing an empty line at the bottom will fix the CI issue.
Ah. I see. Brb. |
Note that is says:
It seems there's only your name in it? That looks weird in the about view. |
I think I should've got it right by now. I hope. |
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 27.71% 27.72% +0.01%
==========================================
Files 25 25
Lines 1761 1760 -1
Branches 213 213
==========================================
Hits 488 488
+ Misses 1256 1255 -1
Partials 17 17
Continue to review full report at Codecov.
|
I created a Norwegian translation for DNS66, based on what I could see of how the other translations on GitHub did it.
Note: Language ISO codes for Norwegian are slightly messy, so I wasn't sure whether to name the folder "values-nb" or "values-no" in order for the translation to be used for Norwegian Android users.