Tweaks for refactored julia internal parser interface #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flisp parser is now available via Core.Compiler.fl_parse rather than via a ccall to jl_parse_string. jl_parse_string will redirect to Core._parse, which may be CSTParser if the Julia parser has been overridden.
c42f
force-pushed
the
cjf/julia-parser-api
branch
from
31b2921 to
3280209
Compare
|
Please hold off merging this until we are finished with the VS Code release plans we have for this week. |
|
No worries, I saw your notice! |
|
What is the status of this? |
|
Waiting for review |
ZacLN
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flisp parser is now available via Core.Compiler.fl_parse rather than
via a ccall to jl_parse_string. jl_parse_string will redirect to
Core._parse, which may be CSTParser if the Julia parser has been
overridden.
See the upstream PR for details of the internal changes to the Julia runtime
JuliaLang/julia#35243