Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have_attributes matcher clashes with rspec-expectations v3.4.0 #4

Closed
gabrielgasser opened this issue Nov 8, 2017 · 2 comments
Closed

have_attributes matcher clashes with rspec-expectations v3.4.0 #4

gabrielgasser opened this issue Nov 8, 2017 · 2 comments
Assignees
@stas
Labels
bug

Comments

@gabrielgasser
Copy link

Thanks for this gem, it's really helpful.

The matcher have_attributes clashes with rspec-expectations v3.4.0. I reckon it would be nice to have something like have_jsonapi_attributes or similar.

Cheers.
@caseyprovost
Copy link

Just ran into this today as well.

@stas
Copy link
Collaborator

stas commented Jan 17, 2020

We'll provide a fix in the next release...

@stas stas self-assigned this Jan 17, 2020
@stas stas added the bug label Jan 17, 2020
@stas stas mentioned this issue Jan 20, 2020
Closed
stas added a commit that referenced this issue Jan 21, 2020
@stas
Rename into have_jsonapi_attributes
d4749a6 
RSpec core matchers already have a `have_attributes` matcher.

The matcher is extended to check strictly the number of attributes.

Closes #4
@stas stas closed this as completed in 69dadbf Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stas stas

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stas @caseyprovost @gabrielgasser