Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Options to change the collapsible-icons #2267

Closed
wants to merge 1 commit into from
Closed

Options to change the collapsible-icons #2267

wants to merge 1 commit into from

Conversation

negue
Copy link
Contributor

@negue negue commented Aug 11, 2011

Now you can change the Icons for collapsible-plugin:

$.mobile.collapsible.prototype.options.iconClosed = "arrow-d";
$.mobile.collapsible.prototype.options.iconOpened = "arrow-u";

@gseguin
Copy link
Contributor

gseguin commented Aug 12, 2011

Why don't you override the .ui-icon-plus and .ui-icon-minus classes instead?

@negue
Copy link
Contributor Author

negue commented Aug 13, 2011

Wouldn't that be redundant code?

e.g. you have custom Icons like ui-icon-myIcon, and have to change them, then you don't have change the also overridden collapsible-ui-icon-plus ...

In my opinion it would be also more flexible, than using css-overrides.

@johnbender
Copy link
Contributor

@eugenb1

Added to the feature request wiki page. We'll be going through that list post 1.0. Thanks!

@johnbender johnbender closed this Nov 11, 2011
@raldred
Copy link

raldred commented Mar 20, 2012

I've run in to this aswell.
Overriding the CSS is clunky, the existing behaviour is out of sync with other jqm elements.

In addtion to this pull request, why not have the ability to change the icon in the same way others icons are configurable, with the data-icon attribute?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants