Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java.nio.file import in AutoCloseable example #1021

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

HyukjinKwon
Copy link
Contributor

This PR proposes to fix the import in AutoCloseable example. The current example fails as below:

>>> from java.nio.files import Files, Paths
Traceback (most recent call last):
  File "org.jpype.JPypeContext.java", line -1, in org.jpype.JPypeContext.callMethod
  ...
java.lang.ClassNotFoundException: java.lang.ClassNotFoundException: java.nio.files
  ...
ImportError: Failed to import 'java.nio.files'

It has to be java.nio.file:

>>> from java.nio.file import Files, Paths

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #1021 (4b0c837) into master (bbdca90) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1021   +/-   ##
=======================================
  Coverage   89.10%   89.11%           
=======================================
  Files         112      112           
  Lines       10041    10041           
  Branches     3972     3972           
=======================================
+ Hits         8947     8948    +1     
  Misses        658      658           
+ Partials      436      435    -1     
Impacted Files Coverage Δ
native/common/include/jp_primitive_accessor.h 74.16% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdca90...4b0c837. Read the comment docs.

@Thrameos Thrameos merged commit 7e12ac6 into jpype-project:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants