Ability to pass 'properties' to Bunny session #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. The goal of this PR makes sense. We'll test as time permits. |
With this change we will be able to define a `properties` property in
the `Sneakers` configuration, that will be passed to `Bunny` when a
connection is created.
```ruby
Sneakers.configure({
amqp: 'amqp://guest:guest@localhost:5672',
properties: {
key: "value",
key2: "value2"
}
})
```
This can be useful, for example, to identify where a connection is
coming from, when we have dozens of applications using a `RabbitMQ` instance.
This is something that can already be done with `Bunny`:
```ruby
Bunny.new(connection_string, { properties: { key: 'value' } })
```
So we are just leveraging that functionality when the connection is
created from `Sneakers`.
brianstorti
force-pushed
the
pass-properties-to-bunny
branch
from
90fd20f to
a412ccc
Compare
michaelklishin
approved these changes
Apr 15, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we will be able to define a
propertiesproperty in theSneakersconfiguration, that will be passed toBunnywhen a connection is created.This can be useful, for example, to identify where a connection is coming from, when we have dozens of applications using a
RabbitMQinstance.This is something that can already be done with
Bunny:So we are just leveraging that functionality when the connection is created from
Sneakers.These properties will be shown in the Management UI like this: