Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NestJS 11 #1216

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Support NestJS 11 #1216

merged 2 commits into from
Jan 27, 2025

Conversation

xballoy
Copy link
Contributor

@xballoy xballoy commented Jan 27, 2025

Support NestJS v11:

Fixes #1215

Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: ce3d4f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nest-commander-schematics Minor
nest-commander-testing Minor
nest-commander Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xballoy xballoy changed the title Nest11 support Support NestJS 11 Jan 27, 2025
Copy link

gitguardian bot commented Jan 27, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
15197365 Triggered Generic Password 306b01e pnpm-lock.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Comment on lines +33 to +34
"@angular-devkit/core": "19.0.1",
"@angular-devkit/schematics": "19.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Must be the same version than the one in @nestjs/schematics to prevent typing issues.

Comment on lines +2 to +4
'nest-commander-schematics': minor
'nest-commander-testing': minor
'nest-commander': minor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

I specified a minor change but I can change to major if you think this is needed.

@xballoy xballoy mentioned this pull request Jan 27, 2025
1 task
@jmcdo29 jmcdo29 merged commit bc3c7f4 into jmcdo29:main Jan 27, 2025
10 of 11 checks passed
@jmcdo29
Copy link
Owner

jmcdo29 commented Jan 27, 2025

Thank you! Been hectic since the release, so I appreciate someone helping out with this!

@xballoy xballoy deleted the nest11-support branch January 27, 2025 20:13
jmcdo29 added a commit that referenced this pull request Jan 27, 2025
Follow-up on #1216, I forgot to bump `@nestjs/core` in the dependencies.

No need for changeset as this only impact the dev environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with NestJS 11
2 participants