fix(election): retry participating if the lease is improperly lost #60
+107
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR do?
This PR fixes an issue where a prometheus-elector instance could stop participating into the election indefinitely if it loses (ie: without releasing it explicitly) the election lease.
In that case, the
LeaderElector.Run
method (see here) exits, this is actually documented 🤦 .But the previous implementation didn't account for that and it was leading to the actual member not taking part into the election anymore.
This PR fixes this issue by checking if the given
runCtx
is done or not afterRun
exits.elector.Run
to join back the election again.How to Test This PR?
Good PR Checklist
Additional Notes