-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display filter rank options in frontend #11910
base: main
Are you sure you want to change the base?
display filter rank options in frontend #11910
Conversation
b2c4106
to
7798657
Compare
...ebapp/app/module/primary/landscape-rank-module-filter/LandscapeRankModuleFilter.component.ts
Outdated
Show resolved
Hide resolved
...ebapp/app/module/primary/landscape-rank-module-filter/LandscapeRankModuleFilter.component.ts
Outdated
Show resolved
Hide resolved
...ebapp/app/module/primary/landscape-rank-module-filter/LandscapeRankModuleFilter.component.ts
Outdated
Show resolved
Hide resolved
...ebapp/app/module/primary/landscape-rank-module-filter/LandscapeRankModuleFilter.component.ts
Outdated
Show resolved
Hide resolved
src/main/webapp/app/module/primary/landscape/Landscape.component.ts
Outdated
Show resolved
Hide resolved
@qmonmert: Thank you for the review. I have pushed the fixes. Let me know if you need some changes ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for your work here @renanfranca Here some first feedbacks:
My 1st suggestion:
What do you think? |
😃
Can you share the exactly Rank configuration setup you use for this test? So, I will be able to reproduce this bug when it draws the modules' connections👍. Do you agree that is the main problem?
I tried it while developing it. It looked weired displaying a module without it's dependency which could be from a different rank.
Today, it is showing the dependencies modules or features related to selected Rank, This way, delivery the correct filter and the screen don't get too crowded.
Don't you need to see the irrelevant modules to try them out, and one day, they might be ranked up? Thanks @pascalgrimaud for try it out! |
another comment: when you select a module, then, select another rank, all selected modules are cleaned |
2189f99
to
433a817
Compare
@pascalgrimaud: I fixed the connection drawing problem, I wasn't looking for nested feature and module dependencies with different ranks than the rank filter applied. Desktop.2025.03.10.-.16.19.39.01.mp4I created a new TO-DO at the description to track the requests.
|
…at Landscape screen
…ModuleRankStatistics
… using color definitions from button-main
…n which put null values at landscapeElements variable at Landscape.component.ts
…e clearing landscapeElements to be rebuilt
…omise returned from reloadLandscape is ignored
…an the rank filter applied
433a817
to
ae702e1
Compare
@pascalgrimaud: It is working now without missing any module states. I tried it with the module rank classification, and it is working really well! I changed this PR to Draft because I need to thoroughly refactor the Landscape.ts class 😄👌 |
A demo video of the implemented feature:
20250214-rank_filter_demo.mp4
There were many things going on in the above demo video so I will list the completed tasks below.
Rank Module Filter Implementation Tasks
UI Components
Rank Filtering Logic
Module Emphasis
Integration
Design
The dark mode Landscape screen with rank module filter
TO-DO (created at 2025-03-10)