Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows #727

Merged
merged 25 commits into from
Mar 30, 2022
Merged

Conversation

DanielFran
Copy link
Member

No description provided.

@DanielFran DanielFran requested a review from mshima March 29, 2022 15:03
@DanielFran
Copy link
Member Author

@mshima To reuse build-matrix from generator project we need some updates on the path for the 99-build-changes.sh script?

@mshima
Copy link
Member

mshima commented Mar 29, 2022

@DanielFran seems you are right.
setup action uses absolute path.
https://github.com/jhipster/generator-jhipster/blob/72d9ac5cf17dfbd320cba1524dbba4c01b1fb65e/.github/actions/setup/action.yml#L109-L112

We can add the parameter or just use ${{ github.workspace }}/generator-jhipster/test-integration default.

@mshima
Copy link
Member

mshima commented Mar 29, 2022

I will take a look, just found a bug at build-changes script.

@DanielFran DanielFran marked this pull request as ready for review March 30, 2022 16:56
@DanielFran DanielFran merged commit 7532aaf into jhipster:main Mar 30, 2022
@DanielFran
Copy link
Member Author

Thanks @mshima

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants